Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI-CD] GitHub Action #270

Merged
merged 38 commits into from
Jun 24, 2021
Merged

[CI-CD] GitHub Action #270

merged 38 commits into from
Jun 24, 2021

Conversation

danielogen
Copy link
Collaborator

Summary of Changes (What does this PR do?)

  • Creates GitHub action for the deployment of Platform (frontend)

Is this change ready to hit production in its current state?

  • Yes
  • No

Status of maturity (all need to be checked before merging):

  • I consider this code done
  • I've tested this locally
  • This branch has been LGTM'ed by a reviewer

How should this be manually tested?

N/A

What are the relevant tickets?

N/A

@danielogen danielogen changed the title create GitHub action for platform deployment [CI-CD] GitHub Action Jun 7, 2021
@danielogen danielogen self-assigned this Jun 7, 2021
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielogen
Awesome stuff! Lovely! :) Also left a few thoughts for future works. :)

@@ -0,0 +1,83 @@
name: deploy-platform-staging

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, aren't we able to reuse the same configuration file for multiple environments? @danielogen
But I guess it is not yet possible as seen here: actions/starter-workflows#245

@Baalmart Baalmart merged commit cf53512 into staging Jun 24, 2021
@Baalmart Baalmart deleted the ft-deploy-platform branch June 24, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants